From de68427afb3866b4c100fc35487409d901f51812 Mon Sep 17 00:00:00 2001
From: Shivam Mathur <shivam_jpr@hotmail.com>
Date: Thu, 28 Nov 2019 06:10:27 +0530
Subject: [PATCH] Bump to 7.4.0 stable on windows and macOS

---
 package-lock.json     | 28 +++++++++++++++++++++-------
 src/scripts/7.4.sh    |  5 +++--
 src/scripts/win32.ps1 |  4 +---
 3 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 4817f005..d5330589 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -2249,12 +2249,14 @@
         "balanced-match": {
           "version": "1.0.0",
           "bundled": true,
-          "dev": true
+          "dev": true,
+          "optional": true
         },
         "brace-expansion": {
           "version": "1.1.11",
           "bundled": true,
           "dev": true,
+          "optional": true,
           "requires": {
             "balanced-match": "^1.0.0",
             "concat-map": "0.0.1"
@@ -2269,17 +2271,20 @@
         "code-point-at": {
           "version": "1.1.0",
           "bundled": true,
-          "dev": true
+          "dev": true,
+          "optional": true
         },
         "concat-map": {
           "version": "0.0.1",
           "bundled": true,
-          "dev": true
+          "dev": true,
+          "optional": true
         },
         "console-control-strings": {
           "version": "1.1.0",
           "bundled": true,
-          "dev": true
+          "dev": true,
+          "optional": true
         },
         "core-util-is": {
           "version": "1.0.2",
@@ -2396,7 +2401,8 @@
         "inherits": {
           "version": "2.0.3",
           "bundled": true,
-          "dev": true
+          "dev": true,
+          "optional": true
         },
         "ini": {
           "version": "1.3.5",
@@ -2408,6 +2414,7 @@
           "version": "1.0.0",
           "bundled": true,
           "dev": true,
+          "optional": true,
           "requires": {
             "number-is-nan": "^1.0.0"
           }
@@ -2422,6 +2429,7 @@
           "version": "3.0.4",
           "bundled": true,
           "dev": true,
+          "optional": true,
           "requires": {
             "brace-expansion": "^1.1.7"
           }
@@ -2429,12 +2437,14 @@
         "minimist": {
           "version": "0.0.8",
           "bundled": true,
-          "dev": true
+          "dev": true,
+          "optional": true
         },
         "minipass": {
           "version": "2.3.5",
           "bundled": true,
           "dev": true,
+          "optional": true,
           "requires": {
             "safe-buffer": "^5.1.2",
             "yallist": "^3.0.0"
@@ -2453,6 +2463,7 @@
           "version": "0.5.1",
           "bundled": true,
           "dev": true,
+          "optional": true,
           "requires": {
             "minimist": "0.0.8"
           }
@@ -2533,7 +2544,8 @@
         "number-is-nan": {
           "version": "1.0.1",
           "bundled": true,
-          "dev": true
+          "dev": true,
+          "optional": true
         },
         "object-assign": {
           "version": "4.1.1",
@@ -2545,6 +2557,7 @@
           "version": "1.4.0",
           "bundled": true,
           "dev": true,
+          "optional": true,
           "requires": {
             "wrappy": "1"
           }
@@ -2666,6 +2679,7 @@
           "version": "1.0.2",
           "bundled": true,
           "dev": true,
+          "optional": true,
           "requires": {
             "code-point-at": "^1.0.0",
             "is-fullwidth-code-point": "^1.0.0",
diff --git a/src/scripts/7.4.sh b/src/scripts/7.4.sh
index 71661cfb..723dcaac 100644
--- a/src/scripts/7.4.sh
+++ b/src/scripts/7.4.sh
@@ -16,7 +16,7 @@ add_log() {
     printf "\033[31;1m%s \033[0m\033[34;1m%s \033[0m\033[90;1m%s\033[0m\n" "$mark" "$subject" "$message"
   fi
 }
-version='7.4.0RC6'
+version='7.4.0'
 step_log "Setup dependencies"
 for package in pkg-config autoconf bison re2c openssl@1.1 krb5 enchant libffi freetype intltool icu4c libiconv t1lib gd libzip gmp tidyp libxml2 libxslt postgresql curl;
 do
@@ -78,13 +78,14 @@ source ~/.bash_profile >/dev/null 2>&1
 source ~/.bashrc >/dev/null 2>&1
 
 step_log "Setup PHP and Composer"
-phpbrew install -j 6 $version +dev >/dev/null 2>&1
+phpbrew install -j 6 github:php/php-src@PHP-$version as php-$version +dev >/dev/null 2>&1
 phpbrew switch $version
 sudo ln -sf /opt/phpbrew/php/php-$version/bin/* /usr/local/bin/
 sudo ln -sf /opt/phpbrew/php/php-$version/etc/php.ini /etc/php.ini
 ini_file=$(php --ini | grep "Loaded Configuration" | sed -e "s|.*:s*||" | sed "s/ //g")
 ext_dir=$(php -i | grep "extension_dir => /opt" | sed -e "s|.*=> s*||")
 pecl config-set php_ini "$ini_file" >/dev/null 2>&1
+pear config-set php_ini "$ini_file" >/dev/null 2>&1
 sudo chmod 777 "$ini_file"
 brew install composer >/dev/null 2>&1
 
diff --git a/src/scripts/win32.ps1 b/src/scripts/win32.ps1
index d8a621a5..0ba5b11e 100644
--- a/src/scripts/win32.ps1
+++ b/src/scripts/win32.ps1
@@ -33,9 +33,7 @@ if ($null -eq $installed -or -not("$($installed.Version).".StartsWith(($version
   if ($version -lt '7.0') {
     Install-Module -Name VcRedist -Force
   }
-  if ($version -eq '7.4') {
-    $version = '7.4RC'
-  }
+
   Install-Php -Version $version -Architecture x86 -ThreadSafe $true -InstallVC -Path $php_dir -TimeZone UTC -InitialPhpIni Production -Force >$null 2>&1
   $installed = Get-Php -Path $php_dir
   $status = "Installed PHP $($installed.FullVersion)"